lensapp/lens

Incorrect behaviour when window is minimised

Open

#7029 opened on Jan 26, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (22,003 stars) (1,433 forks)batch import
buggood first issuep2

Description

Describe the bug When window is minimised (but not closed) the "Open Lens" button in the tray menu seems to have no effect.

To Reproduce Steps to reproduce the behaviour:

  1. Launch Lens
  2. Minimise main window
  3. Click on tray icon
  4. Click "Open Lens"

Expected behaviour The main window becomes unminimized

Contributor guide

Tech stack
typescriptelectronnodejs
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Electron window managementTypeScript familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the tray module (likely src/main/tray.ts) to find the event handler for the 'Open Lens' button. The bug occurs when the main window is minimized; the handler likely fails to restore the window. Check if the window object's show() or restore() method is called correctly, and ensure the window is referenced properly after minimization.