lensapp/lens

binary_download to work from behind a proxy

Open

#6,194 opened on Sep 7, 2022

View on GitHub
 (0 comments) (5 reactions) (0 assignees)TypeScript (22,003 stars) (1,433 forks)batch import
area/buildenhancementgood first issue

Description

What would you like to be added:

  • For binary.download to be able to use proxy ENV variables

Why is this needed:

  • To be able to download the 3 binaries when behind a proxy and building from source

Environment you are Lens application on:

  • RHEL 8.6 x86_64 VM.
  • Lens 6.0.1 git clone.

Contributor guide

Tech stack
typescript
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of HTTP proxiesfamiliarity with Node.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the binary download mechanism in Lens, likely in the build scripts or electron builder configuration. The proxy support should use environment variables like HTTP PROXY and HTTPS PROXY. Modify the download function in the main process to pass proxy settings to Node.js http requests. Refer to the electron builder docs for adding proxy support.