lensapp/lens

Issue when try to see Endpoints details without endpoints defined.

Open

#3763 opened on Sep 9, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (22,003 stars) (1,433 forks)batch import
buggood first issue

Description

Describe the bug Issue when I try to see Endpoints without endpoints defined.

To Reproduce Click on Endpoints that have no endpoint subsets defined.

Expected behavior See endpoints without endpoint subsets

Environment (please complete the following information):

  • Lens Version: 5.2.0-latest.20210908.1
  • OS: Windows 10

Screenshot: Annotation 2021-09-09 112804

Logs:

Component stack:


    at Table (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:592961:9)
    at div
    at EndpointSubsetList (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:619106:47)
    at div
    at EndpointDetails (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:619227:40)
    at div
    at div
    at div
    at Animate (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:136926:9)
    at drawer_Drawer (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:593455:9)
    at KubeObjectDetails (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:606210:9)
    at ErrorBoundary (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:578856:47)
    at ErrorBoundary (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:578965:36)
    at Router (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:32134:30)
    at App (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:672731:9)
    at ThemeProvider (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:700877:24)




TypeError: items is not iterable
    at Table.renderRows (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:593040:83)
    at Table.render (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:593073:18)
    at allowStateChanges (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:1472:12)
    at http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:10151:59
    at trackDerivedFunction (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:2024:18)
    at Reaction.track (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:2552:18)
    at Table.reactiveRender [as render] (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:10149:14)
    at Table.makeComponentReactive (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:10164:25)
    at Table.target.render (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:10077:34)
    at qi (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542309:188)
    at pi (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542308:173)
    at ck (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542391:427)
    at bk (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542372:347)
    at ak (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542372:278)
    at Tj (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542372:138)
    at Lj (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542365:163)
    at http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542245:115
    at exports.unstable_runWithPriority (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542456:343)
    at gg (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542244:325)
    at jg (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542245:61)
    at ig (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542244:428)
    at Hb (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542414:101)
    at gd (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:542195:352)
    at HTMLDivElement.sentryWrapped (http://9d9136df3ab69b182be9f3f0ad1996d7.localhost:59573/build/Lens.js:251524:23)

Contributor guide

Tech stack
typescriptreact
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptDebugging UI components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The bug occurs in the EndpointDetails component which renders EndpointSubsetList. The stack trace indicates that the Table component receives a non iterable value for its items prop. Likely, when an endpoint has no subsets defined, the subsets data is undefined or null. The fix involves adding a guard to ensure that subsets is always an array before passing it to the Table component. Look at the EndpointSubsetList component in the codebase, likely in a file related to endpoints. Ensure that if subsets is falsy, default to an empty array or use optional chaining.