lenra-io/lenra_cli

[Bug]: Cancelling terminal commands does not work

Open

#405 opened on May 15, 2024

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Rust (2 forks)auto 404
buggood first issue

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

What happened?

I tried to cancel build command that was launched from the lenra terminal but the command has not been canceled.

To reproduce:

lenra

Then start a build command:

build

End cancel it with Ctrl + C.

The command will continue.

I tried many commands and for now the only one that cancel is the dev one, because of it custom management of Ctrl + C.

What browsers are you seeing the problem on?

No response

Version

1.3.0

Relevant log output

No response

Contributor guide

Research direction
Investigate the Ctrl+C signal handling in the CLI and trace why it fails to cancel commands except 'dev'.
Tech stack
rust
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70