leinardi/mypy-pycharm

Static methods missing a type definition are highlighted incorrectly

Open

#19 opened on Sep 27, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (30 forks)github user discovery
Priority: MediumStatus: AcceptedStatus: StaleType: Bughelp wanted

Repository metrics

Stars
 (207 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Step 1: Are you in the right place?

  • I have verified there are no duplicate active or recent bugs, questions, or requests
  • I have verified that I am using the latest version of the plugin.

Step 2: Describe your environment

  • Plugin version: 0.10.2
  • PyCharm/IDEA version: PyCharm 2018.2
  • Mypy version: 0.620

Step 3: Describe the problem:

Steps to reproduce:

  1. Write a method annotated with @staticmethod.
  2. Run the mypy checker.

Observed Results:

The highlight exposing a missing type definition starts immediately after the staticmethod annotation and ends right before def.

Expected Results:

def should be highlighted.

Relevant Code:

    @staticmethod
    def email_sent_on(obj):
        return obj.created_on

Contributor guide

Research direction
Locate the inspection class handling static methods in the plugin code and adjust the highlight range to start at 'def' instead of after '@staticmethod'.
Tech stack
javapython
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaPythonMypy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75