leinardi/FloatingActionButtonSpeedDial

TalkBack no longer focuses last action button

Open

#194 opened on Feb 29, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (1,418 stars) (137 forks)batch import
help wanted

Description

Step 1: Are you in the right place?

  • I have verified there are no duplicate active or recent bugs, questions, or requests
  • I have verified that I am using the latest version of the library.

Step 2: Describe your environment

  • Library version: 3.3.0
  • Android version: 13
  • Support library version: ?
  • Device brand: OnePlus
  • Device model: 7T

Step 3: Describe the problem:

Steps to reproduce:

  1. Click main FAB

Observed Results:

  • FAB remains focused

Expected Results:

  • An action button gets focused

Relevant Code:

This is a regression from 3.2.0, probably introduced by https://github.com/leinardi/FloatingActionButtonSpeedDial/commit/5c9afda67c4db822cc793006e1b60637877ce08d. Focusing one of the buttons was implemented in https://github.com/leinardi/FloatingActionButtonSpeedDial/commit/6653f9182323add0624d593432e1c33f71c7b0d0 and now no longer works.

Contributor guide

Tech stack
javaandroid
Domain
mobileaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic Android developmentUnderstanding of TalkBack accessibility
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The bug is a regression introduced by commit 5c9afda67c4db822cc793006e1b60637877ce08d. The focusing logic was originally implemented in commit 6653f9182323add0624d593432e1c33f71c7b0d0. Investigate the changes in the relevant file(s) from that commit to understand why the focus is no longer being set. Look for any conditional checks or modifications that might skip the focus call for the last action button. Compare the current behavior with the expected behavior described in the issue.