leecade/react-native-swiper

Horizontal={false} not working in Android.

Open

#439 opened on Jun 15, 2017

View on GitHub
 (10 comments) (3 reactions) (0 assignees)JavaScript (10,334 stars) (2,346 forks)batch import
help wanted

Description

This moves the dots to the right, but swiping is still left to right.

Contributor guide

Tech stack
javascriptreact nativeandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React NativeAndroid development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the horizontal prop implementation in the swiper component's source code. Look for how the swipe direction is determined and why it remains left to right on Android even when horizontal={false}. Check if there is platform specific code for Android that overrides the prop. Test on an Android emulator and consider adding a vertical swipe handler.