leecade/react-native-swiper

v1.5.0 code-review request

Open

#243 opened on Sep 22, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (2,346 forks)batch import
help wanted

Repository metrics

Stars
 (10,334 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

ref: https://github.com/leecade/react-native-swiper#changelogs

There are two Major changes:

  1. Adjust project structure, publish with src file, use watch-copy script and relative dependencies for improve develop workflow

    "dependencies": {
    "react-native-swiper": "../"
},

  2. ES6 syntex and standard[https://github.com/feross/standard] code style

Please help for more tests and code review, then release 1.5.0, thanks a lot.

@rajkissu @sunnylqm @tasiyo7333 @getnashty

Contributor guide

Research direction
Review the project restructuring and ES6 conversion for correctness, and write additional tests to ensure the changes work as expected.
Tech stack
javascript
Domain
mobile dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React NativeGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65