leecade/react-native-swiper

v1.5.0 code-review request

Open

#243 opened on Sep 22, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (10,334 stars) (2,346 forks)batch import
help wanted

Description

ref: https://github.com/leecade/react-native-swiper#changelogs

There are two Major changes:

  1. Adjust project structure, publish with src file, use watch-copy script and relative dependencies for improve develop workflow

    "dependencies": {
    "react-native-swiper": "../"
},

  2. ES6 syntex and standard[https://github.com/feross/standard] code style

Please help for more tests and code review, then release 1.5.0, thanks a lot.

@rajkissu @sunnylqm @tasiyo7333 @getnashty

Contributor guide

Tech stack
javascriptreact
Domain
mobile
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React Native basicsES6 syntaxCode review experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the project structure changes and ES6 refactoring in the `src` directory. Compare with the previous structure. Check for adherence to standard code style (feross/standard). Look for any missing tests or potential regressions. The maintainer may have additional comments in the linked changelogs.