leecade/react-native-swiper

Swiper 'horizontal' not working on Android

Open

#1082 opened on Oct 4, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (10,334 stars) (2,346 forks)batch import
help wanted🚧processing

Description

Which OS ?

Android 9+

Version

  • react-native-swiper v1.5.14
  • react-native v0.59.5

Expected behaviour

On android device, the swiping orientation is still horizontal, no matter that the parameter horizontal is setted to false.

On IOS is working without any issues.

Contributor guide

Tech stack
javascriptreact nativeandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React Native fundamentalsAndroid development environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the platform specific code in the Swiper component, especially the scroll view handling and orientation detection. The issue is that the `horizontal` prop is ignored on Android. Look at the `onLayout` and gesture handling functions that differentiate between platforms using Platform.OS. Check the source file (likely `src/index.js`) for any conditional logic that might be failing on Android. Test on an Android emulator to reproduce and identify the root cause.