ldtteam/minecolonies-features

Separate Military jobs from Civilian jobs in the Town Hall

Open

#667 opened on Apr 23, 2022

View on GitHub
 (0 comments) (7 reactions) (0 assignees) (2 forks)auto 404
Enhancement / Change RequestGood First Issue

Repository metrics

Stars
 (14 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Prerequisites

  • I am running the latest alpha version of MineColonies for my Minecraft version.
  • I checked the MineColonies/Structurize wiki and made sure that my issue is not covered there.
  • I made sure that this change request is not a duplicate of any existing change request.

Context

  • Minecraft Version: 1.18.2
  • MineColonies Version: 1.0.636-BETA
  • Related Mods and their Versions:

Is your feature request related to a problem?

Looks wrong to see unfilled jobs in the Information tab in the Townhall, before realizing it's military jobs that's unfilled.

Also doesn't feel good having to calculate how many beds are available for children to be born into, by subtracting the military jobs from the 'max number of citizens'.

Enhancement or Change description

Would look better if one could see the listing as, ex. Number of Military: 20/28

  • Archer: 8
  • Knight: 10
  • Druid: 2
  • Knight Trainee: 0/2
  • Archer Trainee: 0/2

Number of Civillians: 18/32

  • Children: 1
  • Unemployed: 0
  • Builder: 2/2
  • Cook: 1/1
  • etc etc

Notes or related things

Viewers

  • Add a thumbs-up to the change request to vote for it. This helps the request become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.

Contributor guide

Research direction
Examine the Town Hall UI code to separate military and civilian job displays.
Tech stack
java
Domain
game dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65