lbryio/lbrycrd

allow bip44 address option when creating wallet

Open

#294 opened on Jul 8, 2019

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)C++ (173 forks)auto 404
hacktoberfestlevel: 3type: new feature

Repository metrics

Stars
 (2,528 stars)
PR merge metrics
 (PR metrics pending)

Description

Torba and lbrycrd use a different standard (bip44 vs bip32) so private keys do not produce the same set of addresses. I understand we don't want the bip44 method to be the default, but there should be an option to do so when creating a wallet.

Contributor guide

Research direction
Examine the wallet creation flow in the source code. Identify where the BIP32 derivation is implemented. Then extend it to support BIP44 as an option, ensuring backward compatibility.
Tech stack
cpp
Domain
backendblockchain
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitBlockchain fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65