lbryio/lbry-sdk

Add type to supports data

Open

#919 opened on Sep 22, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (7,220 stars) (500 forks)batch import
area: jsonrpchelp wantedlevel: 1type: improvement

Description

The Issue

Currently, when you list claim information (claim_list_mine/claim_show/resolve/claim_list) that shows supports, you can't tell if it's a classical support or a tip. We should add a type attribute to each support. If someone sends a tip to themselves, it's treated the same way as a classical support, so not sure which way it needs to be captured.

This will be an important field to report of off for search results and have available in the block explorer.

Expected behaviour

Support should show if it's a tip or not

Actual behaviour

Can't tell if support is a tip or classic support

Contributor guide

Tech stack
python
Domain
blockchainbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic PythonUnderstanding of LBRY claim data model
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review the current support data structure in the LBRY SDK, likely in files such as `lbry/schema/claim.py` or similar. Check existing comments in issue #919 for any proposed approaches. Determine where support objects are created and how the 'type' field should be integrated. Update serialization and deserialization to include the new field, ensuring backward compatibility.
Add type to supports data · lbryio/lbry-sdk#919 | Good First Issue