lbryio/lbry-sdk

detect when server is not sending notifications

Open

#3,189 opened on Feb 8, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (7,220 stars) (500 forks)batch import
area: wallethelp wanted

Description

if wallet server stops sending notifications for some reason, client should detect that and switch to another server

for example: if you send a tx and never receive a notification for it, but then you get a new block that contains an address notification for that tx, then you know the server is not sending you notifications

Contributor guide

Tech stack
python
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Pythonbasic understanding of notification systems
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the current notification mechanism in the lbry sdk, likely involving WebSocket or similar. Look at files related to wallet server communication, such as 'lbry/wallet/server.py' or 'lbry/extras/daemon.py'. The issue suggests a timeout detection: if a transaction notification is not received but later a block notification contains it, the server is faulty. A solution could involve a heartbeat or a timeout on expected notifications. Examine existing tests for notification handling to understand the flow.