lbryio/lbry-desktop

Use fee estimator to show estimated fee on spend confirm screen

Open

#903 opened on Dec 27, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
area: uxhacktoberfesthelp wantedlevel: 2priority: lowtype: improvement

Description

The Issue

If a user tries to send their entire LBC balance to an address (not taking into account tx fees), they are presented with the "get credits" modal and the LBC is not sent. We should mention that transaction fees are associated with sending credits. I'm not sure if we have a way to estimate what those fees are right now (it depends on how many UTXOs are part of of the tx), but we should at least have a better message.

Once we do have the fees, we should have a button called "send max" which takes into account the tx fees.

Steps to reproduce

  1. Send entire LBC balance
  2. Get message about credits

System Configuration

  • LBRY Daemon version: 0.18.0
  • LBRY App version: 0.19.2
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Contributor guide

Tech stack
javascript
Domain
frontendblockchain
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptReactElectron basicsLBRY API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Review the spend confirm screen component in the LBRY desktop app (likely in the UI codebase). Examine how transaction sending is currently handled and where fee estimation could be integrated. Look into the LBRY daemon API for fee estimation methods. Additionally, consider implementing a 'send max' button that accounts for transaction fees as suggested in the issue.