lbryio/lbry-desktop

Add an option to build the the app using the elctron installed on the system

Open

#7,117 opened on Sep 17, 2021

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
help wantediceboxlevel: 3type: new feature

Description

Is your feature request related to a problem? Please describe. I use ppc64le architecture and vanilla electron is not compatible... there are patched versions (of electron) available on some GNU/Linux distros like Void-ppc.

Describe the solution you'd like Basically adding an option to the build system that uses the distro's electron

Describe alternatives you've considered Use a precompiled version of electron on ppc64le?

Contributor guide

Tech stack
javascriptelectron
Domain
desktopbuild system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.jsElectronBuild system (e.g., electron builder)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the existing build configuration in package.json and the electron builder config. Research how other Electron apps implement a fallback to system electron (e.g., via environment variable `ELECTRON OVERRIDE DIST` or similar). Check the comment from the author for additional context. The solution likely involves modifying the build script to allow skipping the download of prebuilt Electron and instead use the system installed Electron binary.