lbryio/lbry-desktop

Player: Disable auto-popup of Playback-Rate on hover

Open

#5,715 opened on Mar 19, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
good first issuehelp wantedlevel: 2type: bug

Description

Now that the seek bar goes from end-to-end horizontally, every time I want to seek to near the end, I get blocked by the playback-rate popup if the mouse cursor came from the bottom. It's getting annoying having to avoid the popup.

The popup should only appear after clicked.

image

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue concerns the playback rate popup in the player UI. To implement, locate the relevant component (likely named something like 'PlaybackRateButton' or similar) and change its hover behavior to click only. The source code is in the 'lbry desktop' repository under the 'ui' directory. Check for existing event handlers and modify them accordingly.
Player: Disable auto-popup of Playback-Rate on hover · lbryio/lbry-desktop#5715 | Good First Issue