lbryio/lbry-desktop

The mute icon sometimes does not reflect actual state.

Open

#4358 opened on Jun 9, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
area: viewerhelp wantedtype: bug

Description

Bug The mute icon in the player does not reflect the actual state for this scenario. It's very minor, but would probably impact the "tap to unmute" feature request.

To Reproduce

  1. Open a video and mute it.
  2. Click Back and close the floating player.
  3. Open another video, and click to play (I had "autoplay" set to off). It should then start as muted, and if not, repeat 1 and 2 again.
  4. Press 'm' to unmute. You'll hear the sound, but icon stays as "muted". You might need to wiggle the mouse to keep the controls visible.

If you enter into a video claim with audio played directly, then the 'm' button is in sync with the icon when pressed.

Expected behavior Icons need to reflect actual state.

System Configuration 0.46.1 yarn build, but also seen in lbry.tv today.

Contributor guide

Tech stack
javascriptelectronreact
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React state managementElectron basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The bug occurs in the mute icon within the player UI. Look for the component handling the mute button (likely in src/renderer/player/). The mute state is not synced when pressing 'm' after the sequence described. Check the keypress event handler and ensure the icon's state is updated based on the actual mute status. The issue is isolated and well reproduced.