lbryio/lbry-desktop

Support locking and unlocking of wallet while in use

Open

#2,204 opened on Jan 16, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
area: securityhelp wantedlevel: 3priority: mediumtype: new feature

Description

The Issue

The latest SDK includes an account_lock function that we can use to lock a users wallet while they have the app open. This would be useful when allowing LBRY to run in the background, or when using LBRY in a public setting. I think it should also lock down any changes in the app (i.e. mature content setting/download directory/etc) and put a banner with something along the lines of "wallet is locked, please unlock by clicking here" across the top. When locked, new videos cannot be played, but existing ones should work.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Internal Use

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed

Contributor guide

Tech stack
javascriptreact
Domain
desktopsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
LBRY SDK basicsReact state management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the account lock function in the LBRY SDK to understand the API. Review the current wallet state management in the app (likely in Redux or similar state container). Consider where to add lock/unlock UI, such as in the header or settings panel. Ensure that when locked, video playback is restricted and settings changes are disabled. No linked PRs or comments are available for this issue.