lbryio/lbry-desktop

Flow type errors

Open

#2,024 opened on Oct 10, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
hacktoberfesthelp wanted

Description

We are currently trying to use Flow in every file. We have been slowly making progress but there are still a lot of errors.

If you open a PR with some Flow error fixes (or anything else) we will send you some LBC as appreciation!

Some of the biggest offenders right now are in pages/file/view.jsx and anything with subscriptions.

To see all of the errors you can run ./node_modules/.bin/flow --color always

Contributor guide

Tech stack
javascriptreact
Domain
developer experience
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of FlowNode.js and npm installed
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by running `./node modules/.bin/flow color always` in the project root to list all current errors. Focus on files like `pages/file/view.jsx` and areas related to subscriptions, as they are mentioned as major offenders. Fix simple type annotations first, using existing type definitions in the codebase as a reference. The maintainer offers LBC tokens as appreciation for contributions.