lbryio/lbry-desktop

Expose Full Screen setting in app

Open

#1,815 opened on Jul 24, 2018

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (412 forks)batch import
area: viewerhacktoberfesthelp wantedlevel: 1type: new feature

Repository metrics

Stars
 (3,596 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The Issue

Some users may want to run the LBRY desktop app in full screen (i.e. pressing F11 while in the app). It would be a good idea to expose this setting somewhere in the app - settings page could be appropriate.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Contributor guide

Research direction
Look for the settings page component and find where other settings are defined. Add a toggle for full screen mode using Electron's setFullScreen API.
Tech stack
javascript
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80