lbryio/lbry-desktop

Web Content Should Open in a Web Type View

Open

#1,682 opened on Jun 25, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
area: viewerhelp wantedlevel: 1type: improvement

Description

Having self-contained and lbry:// interlinkable websites is a big selling point for LBRY. However, viewing HTML content is in need of some love. It would be nice to have HTML/web documents open up in fullscreen below the new header, to make the experience more enjoyable.

I also noticed anchor links and context menus don't work with HTML content.

At the time of writing this, this web content I uploaded can be viewed which relates to the above.

lbry://nine#9b6eefab8def087ae26ef900bf62dc0113fe1cfb

image

Contributor guide

Tech stack
javascripthtmlcsselectron
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Electron development environmentReactHTML and CSSLBRY protocol basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Explore the current implementation of HTML content rendering in lbry desktop, likely in a component that handles file display. Investigate the header layout to see how fullscreen can be achieved. Check if anchor links and context menus are handled in the web view component. Review the linked sample content to understand desired behavior.