lbryio/lbry-desktop

Maximized window setting lost if restored from tray after minimizing

Open

#1,199 opened on Mar 28, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (3,596 stars) (412 forks)batch import
area: uxarea: viewergood first issuehacktoberfesthelp wantedlevel: 1priority: mediumtype: bug

Description

The Issue

This seems to affect Windows only. If you have the LBRY app maximized, then minimize (or minimize + close), then try to restore from tray (double click, or right click > Open LBRY), the window returns to the previous un-maximized window size. This will also happen if you have LBRY minimized in such a state and then open a LBRY url like https://open.lbry.io/test

Steps to reproduce

  1. Maximize LBRY window size
  2. Minimize LBRY
  3. Restore from tray
  4. Notice the window is no longer maximized - it may be full screen or use whatever previous non-maximized you had.

Expected behaviour

Window show be restored to last used state, or maximized in this case

Actual behaviour

Window size is restored

System Configuration

  • LBRY Daemon version: 0.19.1
  • LBRY App version: 0.21.2
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Contributor guide

Tech stack
javascriptelectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptElectronwindow state management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the main process and tray handling code to see how window state (maximized) is saved and restored. Look for code related to 'win.setMaximizable' and 'win.maximize' in the main process. The bug likely occurs because the window is restored before setting the maximized state, or the state is not preserved on minimize. Check any state management utilities.