launchbadge/sqlx

Pool should spawn a task when connecting in `acquire()`

Open

#3,513 opened on Sep 20, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (13,916 stars) (1,307 forks)batch import
E-mediumenhancementgood first issuepool

Description

This way, if the acquire() call is cancelled or times out, the connection can still go through.

The connection task should have its own separate timeout, possibly surfaced as PoolOptions::connect_timeout().

This will likely fix:

Contributor guide

Tech stack
rust
Domain
backenddatabase
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rustasync programmingsqlx pool internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the current `acquire()` method in sqlx's pool module, likely in `/sqlx core/src/pool/`. Understand how connections are spawned and consider spawning a separate task with its own timeout. Reference linked issues #3315, #3132, #2848 for additional context and expected behavior.