launchbadge/sqlx

Pool should spawn a task when connecting in `acquire()`

Open

#3,513 opened on Sep 20, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (1,307 forks)batch import
E-mediumenhancementgood first issuepool

Repository metrics

Stars
 (13,916 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This way, if the acquire() call is cancelled or times out, the connection can still go through.

The connection task should have its own separate timeout, possibly surfaced as PoolOptions::connect_timeout().

This will likely fix:

Contributor guide

Research direction
Study the pool implementation in sqlx, focusing on the acquire() method. Understand the current synchronous connection setup and how to spawn an async task with a separate timeout that outlives the acquirer's cancellation. Review the linked issues #2848, #3132, #3315 for additional context.
Tech stack
rust
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50