Error message reflection in /login?error=...
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- authentication, security
Research direction
Start in route.ts at lines 80 and 124, where the rate-limit and OAuth errors are reflected into the redirect URL. Trace the /login?error=... flow, then add or update tests so URLs contain only the canonical codes and document those codes as part of the acceptance criteria.
Written by the indexing model from the issue text.
Description
Summary
Raw rateLimitResult.error and oauthError.message are reflected into redirect URLs.
Source
P2 follow-up from /ship adversarial review of PR #176 (silent GitHub token refresh).
Details
route.ts:80,124 reflect rateLimitResult.error and oauthError.message via encodeURIComponent to a redirect URL.
Fix
Emit fixed error codes only (rate_limited, oauth_failed); keep messages in server logs / Sentry.
Acceptance
- No raw error messages in
/login?error=... - Stable error codes documented
- Tests assert only canonical codes appear in URLs
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 2
- Avg merge
- 6h 9m
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from laststance/gitbox
-
P2-medium testing
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
laststance/gitbox#186 ·
-
P2-medium testing
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
laststance/gitbox#185 ·
-
enhancement P2-medium
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
laststance/gitbox#177 ·
-
P2-medium security
Difficulty 4/5 3-5 days Newbie friendliness 35/100
laststance/gitbox#187 ·
-
P2-medium security
Difficulty 4/5 3-5 days Newbie friendliness 48/100
laststance/gitbox#183 ·
All issues in laststance/gitbox
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100