laravel-shift/curl-converter

Better handling of values containing backslashes

Open

#20 opened on Oct 17, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)PHP (11 forks)user submission
good first issue

Repository metrics

Stars
 (93 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently backslashes (and possibly other characters) are being lost from values as they are passed through Artisan. These need to be escaped so they are preserved in the final output. An appropriately placed call to addslashes should to the trick.

Example curl command:

curl --request POST https://example.com/pdf/extract --header 'Content-Type: multipart/form-data' --form 'file=C:\Users\secret\files\007.pdf'

Contributor guide

Research direction
Locate the conversion logic for HTTP values and add a call to addslashes to preserve backslashes.
Tech stack
phplaravel
Domain
backendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80