lanl/singularity-eos

use consistent forwarding in constructors for PTESolver classes

Open

#619 opened on Mar 21, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (21 forks)auto 404
clean-upgood first issue

Repository metrics

Stars
 (36 stars)
PR merge metrics
 (PR metrics pending)

Description

The PTESolverBase class takes const references to indexers, but the derived classes all use forwarding references but NOT perfect forwarding. A choice should be made here and the solvers should be made consistent.

Contributor guide

Research direction
Investigate the current usage of forwarding references in constructors of PTESolver derived classes, decide on either perfect forwarding or const references, and apply the chosen pattern consistently across all constructors.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
cpp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60