lanl/singularity-eos

Add explicit file and material ID checking to `spinerEOS`

Open

#516 opened on Jun 19, 2025

View on GitHub
 (0 comments) (1 reaction) (0 assignees)C++ (21 forks)auto 404
Robustnessgood first issue

Repository metrics

Stars
 (36 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently, we rely on HDF error messages for missing files or materials, but these can be rather cryptic. We should probably test for the existence of the file and the existence of a material in the SP5 file ourselves to make the error messages cleaner.

Contributor guide

Research direction
Check file existence and material ID existence in SP5 file. Inspect the SpinerEOS constructor and the HDF5 file reading logic. Add checks using standard file I/O and HDF5 group existence checks before proceeding with reading.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75