lanl/singularity-eos

Should we remove forwarding references from PTE solvers?

Open

#438 opened on Nov 29, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (21 forks)auto 404
bugclean-updiscussionhelp wantedinterfacequestion

Repository metrics

Stars
 (36 stars)
PR merge metrics
 (PR metrics pending)

Description

The segfault on HIP was caused by an access-out-of-scope error caused by passing pointers by reference into the PTE solvers. See #437 . Perhaps we should consider removing the forwarding references and pass only by value into the PTE solvers (with the exception of PTE Solver Base, which requires pass-by-reference as it is used as the first part of the derived class constructors).

Ping @jhp-lanl @jdolence @dholladay00 @mauneyc-LANL and @rbberger for feedback

Contributor guide

Research direction
Read issue #437 to understand the segfault caused by passing pointers by reference. Then examine the PTE solver code, focusing on how forwarding references are used. Plan to change only the PTE solvers to pass by value, except for PTE Solver Base. Test the changes on HIP to ensure no segfault.
Tech stack
cpp
Domain
hpc
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40