lanl/singularity-eos

Consider replacing ternary expressions with multiplicative conditionals

Open

#319 opened on Oct 27, 2023

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C++ (21 forks)auto 404
Performancegood first issue

Repository metrics

Stars
 (36 stars)
PR merge metrics
 (PR metrics pending)

Description

Per @Yurlungur we may want to replace

x = cond ? a : b

with

x = (cond) * a + (1 - cond) * b

to reduce branching and improve GPU performance.

This might be premature optimization, but it also might be a good way to specify default handling of NaNs as well.

Contributor guide

Research direction
Search for ternary expressions in GPU related code paths in the repository, evaluate if replacement with multiplicative conditionals improves performance, and test on GPU hardware.
Tech stack
c
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65