lanl/singularity-eos

`-fmax-errors` not support by clang

Open

#315 opened on Oct 20, 2023

View on GitHub
 (12 comments) (0 reactions) (3 assignees)C++ (21 forks)auto 404
Testingbuildhelp wanted

Repository metrics

Stars
 (36 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/lanl/singularity-eos/blob/main/CMakeLists.txt#L449 unconditionally adds -fmax-errors=3 which leads to the following warning:

clang: warning: argument unused during compilation: '-fmax-errors=3' [-Wunused-command-line-argument]

Contributor guide

Research direction
Modify CMakeLists.txt to conditionally add fmax errors=3 only when the compiler is GCC (e.g., using CMAKE COMPILER IS GNU or check c compiler flag).
Tech stack
cpp
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CMakeC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85