langgenius/dify

[Refactor/Chore] add missing-override-decorator

Open

#36406 opened on May 19, 2026

View on GitHub
 (7 comments) (1 reaction) (2 assignees)TypeScript (141,412 stars) (22,210 forks)batch import
good first issuestatus: accepting prs

Description

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

you can use pyrefly check strict to find them.

Motivation

https://peps.python.org/pep-0698/

Additional Context

No response

Contributor guide

Tech stack
python
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Pythonfamiliarity with Python class inheritanceknowledge of @override decorator
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue lists all methods missing the @override decorator with class and method names. Locate each class in the codebase (e.g., RemoteSettingsSourceFactory in core/, DifyConfig, etc.) and add the @override decorator before each method. Ensure the decorator is imported from typing (Python 3.12+) or a compatible library. The error output provides exact locations, so simply search for each class definition and add the decorator.