langgenius/dify

[Chore/Refactor] not call the 'set' function of 'useState' directly in 'useEffect'

Open

#25194 opened on Sep 5, 2025

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (141,412 stars) (22,210 forks)batch import
good first issuerefactor

Description

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

not call the 'set' function of 'useState' directly in 'useEffect'

Motivation

keep logic simpler

Additional Context

https://react.dev/learn/you-might-not-need-an-effect

https://eslint-react.xyz/docs/rules/hooks-extra-no-direct-set-state-in-use-effect

Contributor guide

Tech stack
reacttypescript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React hooks basicsUnderstanding of useEffect and useState
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Review the React documentation at https://react.dev/learn/you might not need an effect and the ESLint rule at https://eslint react.xyz/docs/rules/hooks extra no direct set state in use effect. Identify all components in the codebase where setState is called directly inside a useEffect without condition. Refactor by removing the useEffect and computing state directly from props or previous state, or moving the setState call outside of useEffect if possible. Follow the patterns described in the linked resources.