lancedb/lancedb

examples/simple.rs rust example uses unreleased code

Open

#1153 opened on Mar 23, 2024

View on GitHub
 (10 comments) (1 reaction) (0 assignees)HTML (10,303 stars) (876 forks)batch import
Rustdocumentationgood first issue

Description

Description

In examples/simple.rs it has the following code:

use lancedb::arrow::IntoArrow;

...

fn create_some_records() -> Result<impl IntoArrow> {

   ...

}

but on the latest release lancedb = "0.4.13" there is no IntoArrow trait. For example search for "IntoArrow" in this file.

Link

https://lancedb.github.io/lancedb/basic/#installation

Contributor guide

Tech stack
rust
Domain
backenddocumentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingLanceDB library basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the current example file at examples/simple.rs in the repository. Compare it with the latest release of lancedb (version 0.4.13) to identify the correct API to use instead of IntoArrow. Refer to the documentation at https://lancedb.github.io/lancedb/basic/#installation and the source code in rust/lancedb/src/arrow.rs to find the appropriate trait or method. Update the example accordingly and ensure it compiles and runs with the released version.