lance-format/lance

Parametrize SQL strings

Open

#2,160 opened on Apr 6, 2024

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Rust (695 forks)github user discovery
enhancementgood first issuerust

Repository metrics

Stars
 (6,582 stars)
PR merge metrics
 (Avg merge 6d 1h) (219 merged PRs in 30d)

Description

So users can support potentially untrustworthy inputs, support something like:

.where("id = :id", id = potentially_untrustworthy_string)

Can use placeholders: https://docs.rs/sqlparser/latest/sqlparser/ast/enum.Value.html#variant.Placeholder

And then fill in from there.

Contributor guide

Research direction
Investigate the existing SQL parsing code (sqlparser crate) and query execution path. Identify where SQL strings are compiled and how to inject placeholders. Then modify the query builder to accept parameterized inputs and handle placeholder substitution.
Tech stack
rust
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65