lambdalisue/vim-suda

Cannot retry inputting password

Open

#34 opened on Sep 10, 2020

View on GitHub
 (6 comments) (5 reactions) (0 assignees)Vim Script (28 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (843 stars)
PR merge metrics
 (PR metrics pending)

Description

  1. Create a file owned by root: sudo touch foo.txt
  2. Open an another terminal (to end the sudo's session)
  3. Open vim
  4. :Suda foo.txt
  5. Edit something.
  6. :w
  7. Input an incorrect password.
  8. Error occurs without retry.
Password: ***Error detected while processing BufWriteCmd Autocommands for "suda://*"..function suda#BufWriteCmd[14]..BufWriteCmd Autocommands for "suda://*"..function suda#BufWriteCmd[3]..suda#write:
line   33:
E605: Exception not caught: Sorry, try again.^@Sorry, try again.^@^@sudo: no password was provided^@sudo: 2 incorrect password attempts^@

At this time, suda.vim inputs incorrect password severary. (See the error message.)

Contributor guide

Research direction
Modify the error handling in suda#write to catch the exception and prompt for password again instead of propagating the error.
Tech stack
None
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70