lambdalisue/vim-gina

Failed to patch

Open

#292 opened on Aug 19, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Vim Script (28 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (688 stars)
PR merge metrics
 (PR metrics pending)

Description

It seems patch fails when there is no common suffix among stage, index, and worktree.

For example

|  HEAD    |  INDEX   | WORKTREE |
|+aaaaaaaa |+aaaaaaaa |          |
|+aaaaaaaa |+aaaaaaaa |          |
|          |+aaaaaaaa |+aaaaaaaa |
|          |+aaaaaaaa |+aaaaaaaa |
|+aaaaaaaa |          |          |
|+aaaaaaaa |          |          |
| XXXXXXXX | XXXXXXXX | XXXXXXXX |

works OK while the last XXXXXXXXXX are common among three but

|  HEAD    |  INDEX   | WORKTREE |
|+aaaaaaaa |+aaaaaaaa |          |
|+aaaaaaaa |+aaaaaaaa |          |
|          |+aaaaaaaa |+aaaaaaaa |
|          |+aaaaaaaa |+aaaaaaaa |
|+aaaaaaaa |          |          |
|+aaaaaaaa |          |          |

does not works while the last line is different among theee.

Contributor guide

Research direction
Investigate the diff algorithm used in vim gina's patch functionality when there is no common suffix. Trace the code path that generates the patch and compare it with git's own diff algorithm.
Tech stack
None
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60