lambdalisue/vim-gina

Exit from commit amend screen doesn't commit

Open

#193 opened on Jan 27, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Vim Script (28 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (688 stars)
PR merge metrics
 (PR metrics pending)

Description

If I open a commit screen and toggle amend via !, exiting via :wq correctly amends the commit, but exiting via :q or :x doesn't. I would expect :q to ask for confirmation and :x to work exactly like :wq, which is the behavior in the non-amend commit flow.

Contributor guide

Research direction
Investigate the commit amend screen logic in the plugin's source code to understand why :q and :x do not trigger a commit while :wq does.
Tech stack
None
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70