lambdalisue/jupyter-vim-binding

<esc> returns to Jupyter Mode instead of vim mode in vivaldi

Open

#112 opened on Sep 7, 2017

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (2,062 stars) (139 forks)batch import
Want PRbughelp wanted

Description

Summary

Escape doesn't work as expected.

Environment

  • Operating system : macOS Sierra 10.12.6
  • Web browser : Vivaldi 1.11.917.43 (compared with Chrome 60.0.3112.113)
  • Version or revision of Jupyter Notebook : 4.3.0
  • Revision of jupyter-vim-binding : d6e3886bfe4008215f8e8286d9c0dcdb26debce9

Behavior

Expected

In Insert Mode, pressing escape should return you to vim mode.

Actual

In Insert Mode, pressing escape returns you to jupyter mode.

Step by step procedure

  1. Start local Jupyter Notebook by jupyter notebook
  2. Access http://localhost:8888/ in Vivaldi
  3. Open an existing notebook
  4. With a cell activated, enter insert mode (e.g. press i twice)
  5. Press <esc>, you are immediately taken out of vim mode, there is no cursor.

What you have done to solve the issue

I've tried turning off all extensions (Moly Keys, Moly HaH, LastPass, Google Docs Offline) also running in private mode with no success.

I've compared this with Chrome (60.0.3112.113) running the exact same server and exact same notebook. It works as expected there.

Contributor guide

Tech stack
javascript
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Jupyter Notebook usageJavaScript key event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the escape key handler in the jupyter vim binding extension source code, specifically looking at key event listeners and how they interact with the cell mode. Compare the behavior in Vivaldi vs Chrome, as the issue only occurs in Vivaldi. Check if Vivaldi intercepts the escape key before the extension. Consider using browser detection or adjusting event propagation to ensure the extension receives the keypress. Review any existing comments or similar issues in the repository for clues.