lambdalisue/jupyter-vim-binding

Erroneous Ex commands (e.g., :asdf) breaks vim bindings

Open

#107 opened on Jul 19, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,062 stars) (139 forks)batch import
Want PRenhancementhelp wanted

Description

Summary

Typing an erroneous ex command breaks vim bindings.

Environment

  • [Ubuntu 16.04 64 bit] Operating system : (e.g. Ubuntu Gnome 15.04 64bit)
  • [Chrome 59.0.3071.115] Web browser : (e.g. Firefox 44.0.2)
  • [4.3.0] Version or revision of Jupyter Notebook : (e.g. 4.1 or 620fb29)
  • [ae048fd025c80618238ace589e453dee53553001] Revision of jupyter-vim-binding : (e.g. 5a057d6)

Behavior

Once you type an erroneous ex command, navigation between code cells no longer work until you click on a cell with the mouse. Even after clicking in a cell, navigating within a cell changes the notebook cell focus while staying in insert mode within the clicked cell.

Expected

Vim bindings should work after erroneous ex commands

Actual

Vim bindings break after erroneous ex commands

Step by step procedure

  1. Start local Jupyter Notebook by jupyter notebook
  2. Access http://localhost:8888/
  3. Make multiple cells (shift-esc, o, o, o)
  4. Focus into a cell in the middle (k, i)
  5. Enter erroneous ex command (:asdf)
  6. Attempt to navigate to other cells (j, k)

What you have done to solve the issue

Reproduced with another machine (also running ubuntu, chrome browser)

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptJupyter Notebookvim bindings
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The bug occurs when an erroneous ex command (like :asdf) is entered, causing vim bindings to break. Investigation should focus on the code that processes ex commands, likely in the plugin's integration with CodeMirror's vim mode. Look for error handling or state management after invalid commands.