test: add reason strings to the bare #[ignore] attributes
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start with the 20 locations listed in the issue, especially the bare attributes in the named files under tests/ and src/. Read each adjacent MODEL_DIR, skip message, or trailing comment, then run cargo test -- --list or compile the project. Done means every bare #[ignore] under src/ and tests/ has an appropriate reason string.
Written by the indexing model from the issue text.
Description
Summary
Twenty #[ignore] attributes carry no reason string in the attribute itself, against 335 in the repo that do (#[ignore = "..."]). In every case the reason text is already adjacent in the file: a MODEL_DIR const, an eprintln! skip message, or a trailing comment.
Background
A bare #[ignore] gives no hint in cargo test -- --list about why a test is skipped, so a reader cannot tell a hardware gate from a known-broken test. The convention across the repo is the = "..." form. This is mechanical: copy the adjacent reason into the attribute.
Proposed Solution
Fill each bare #[ignore] with the reason already sitting next to it. No hardware needed; compilation (or cargo test -- --list) verifies.
Implementation Notes
Verified bare sites in the current tree (20 total):
tests/deepseek_v4_real_model.rs:55,111,145,236,362tests/qwen38_mtp_chain_parity.rs:127,202,447,523,612,678tests/ernie4_5_moe_vl_parity.rs:132tests/qwen3_omni_moe_parity.rs:66src/models/diffusion_gemma/tests.rs:448,803src/downloader/tests.rs:547src/tokenizer/tiktoken.rs:368,383,394,405(these carry a// Requires model filestrailing comment but no reason in the attribute)
Note: the two src/models/diffusion_gemma/tests.rs sites were missed by the original enumeration; they are included above.
Convention examples: tests/turbo_kv_e2e.rs:598, :633, :657. Adjacent reason sources: tests/deepseek_v4_real_model.rs:52 (MODEL_DIR) and its skip message; src/tokenizer/tiktoken.rs:368 (// Requires model files); src/downloader/tests.rs skip block.
Acceptance Criteria
- Zero bare
#[ignore]remains undersrc/andtests/.
Original Suggestion
Title: test: add reason strings to the twenty bare #[ignore] attributes
Twenty #[ignore] attributes carry no reason string, against 330 in the repo that do (#[ignore = "..."]). In every bare case the reason text is already sitting adjacent in the file — a MODEL_DIR const, an eprintln! skip message, or a trailing comment.
Evidence
Bare sites: tests/deepseek_v4_real_model.rs:55,111,145,236,362; tests/qwen38_mtp_chain_parity.rs:127,202,447,523,612,678; tests/ernie4_5_moe_vl_parity.rs:132; tests/qwen3_omni_moe_parity.rs:66; src/tokenizer/tiktoken.rs:368,383,394,405; src/downloader/tests.rs:547.
Convention examples: tests/turbo_kv_e2e.rs:598, :633, :657. Adjacent reason sources: tests/deepseek_v4_real_model.rs:52 (MODEL_DIR) and :59-61 (skip message); src/tokenizer/tiktoken.rs:368 (// Requires model files); src/downloader/tests.rs:544-545.
Suggested fix
Copy each adjacent reason into the attribute. No hardware needed; cargo test -- --list (or just compilation) verifies.
Acceptance criteria
- Zero bare
#[ignore]remains undersrc/andtests/
- Dominant language
- Rust
- Stars
- 470
- Forks
- 54
- Avg merge
- 4h 45m
- Merged PRs (30d)
- 305
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lablup/mlxcel
-
area:core priority:low status:ready type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
priority:low status:ready type:docs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
docs(webpage): add a webpage/site README covering the pnpm/uv/zensical build and deploy contract Openpriority:low status:ready type:docs
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
-
docs: CONTRIBUTING says clippy is not gated at PR time, but ci.yml runs -D warnings clippy on PRs Openpriority:medium status:ready type:docs
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
priority:low status:ready type:docs
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gitbutlerapp/gitbutler#15998 · 1 comment ·
-
bug triage:deciding
Difficulty 1/5 Under an hour Newbie friendliness 88/100
open-telemetry/otel-arrow#4132 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100