kynan/nbstripout

Support setting defaults for command line arguments via git config

Open

#189 opened on Jan 27, 2024

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (1,047 stars) (90 forks)batch import
help wantedtype:enhancement

Description

We already support some options being set via git config (extrakeys and keepmetadatakeys).

Ideally, all command line arguments should be configurable in this way the values read from git config should be the defaults for the command line arguments.

Contributor guide

Tech stack
python
Domain
clibackenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python experiencefamiliarity with nbstripout codebaseunderstanding of git config
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests that all command line arguments be configurable via git config, similar to the existing support for 'extrakeys' and 'keepmetadatakeys'. Start by examining the current implementation in nbstripout/ nbstripout.py lines 450-465, which reads from git config. Extend this mechanism to cover other arguments. Consider following a pattern similar to the existing code, and check if there are any tests to update. Since there is an assignee, coordinate with them to avoid duplication of effort.