kubernetes/website

Set text direction based on localization text direction

Open

#46,100 opened on May 1, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)HTML (13,918 forks)batch import
area/localizationhelp wantedkind/featurepriority/backlogtriage/accepted

Repository metrics

Stars
 (4,127 stars)
PR merge metrics
 (Avg merge 16d 13h) (160 merged PRs in 30d)

Description

This is a Feature Request

What would you like to be added Edit the Hugo layout template(s) for the site to set dir on the html element, so that browsers know what text direction is in use.

Why is this needed This change would support or enable https://github.com/kubernetes/website/issues/22730 and https://github.com/kubernetes/website/pull/46042

Comments /area localization /kind feature /help /triage accepted

You should work on this if you have the capacity to and you already understand a little about Hugo templating. The change may not be suitable for a contributor who is new to working with Hugo and Hugo themes.

Contributor guide

Research direction
Examine the Hugo base template (e.g., layouts/ default/baseof.html) and find where the <html> element is opened. Add a check for the page's language code; if it is a right to left language like Arabic, set dir="rtl", otherwise dir="ltr".
Tech stack
go
Domain
localizationfrontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Hugo templating
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50