kubernetes/minikube

Changing a Service from type: LoadBalancer to type: ClusterIP doesn't remove status.loadBalancer.ingress[]

Open

#9,972 opened on Dec 15, 2020

View on GitHub
 (7 comments) (0 reactions) (1 assignee)Go (31,799 stars) (5,222 forks)batch import
help wantedkind/buglifecycle/frozenlong-term-supportpriority/backlog

Description

Steps to reproduce the issue:

  1. minikube start --memory 8192 --cpus 8 --disk-size 80g
  2. minikube tunnel
  3. Create a Service my-svc with type: LoadBalancer
  4. Observe kubectl get service my-svc -o yaml shows status.loadBalancer.ingress[0].ip with the service's clusterIP
  5. kubectl patch service my-svc --type=merge -p "spec: {type: ClusterIP}"

Actual:

status.loadBalancer.ingress[0].ip remains.

Expected:

status.loadBalancer.ingress should be removed.

This would help automated tests that need to work with both minikube and cloud k8s clusters like GKE, that test adding and removing external access on Service.

We took a look at LoadBalancerEmulator, and saw that it has a method cleanupService(). However, it is only called on Services with type: LoadBalancer, and the cleanup methods are only called during shutdown.

Ideally, it seems like PatchServices should reconcile all Services to add or remove status.loadBalancer.ingress as appropriate.

Contributor guide

Tech stack
go
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Kubernetes Service typesGo programmingminikube architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Examine the LoadBalancerEmulator code in the minikube repository, specifically the cleanupService method and the PatchServices function. Understand how Services are currently reconciled and implement logic to remove status.loadBalancer.ingress when the Service type is not LoadBalancer. Check the issue comments for any additional context or suggested approach.