kubernetes/minikube

Command start should delete node with empty ip or retrieve one

Open

#9,834 opened on Dec 3, 2020

View on GitHub
 (17 comments) (0 reactions) (0 assignees)Go (31,799 stars) (5,222 forks)batch import
co/multinodehelp wantedkind/buglifecycle/stalepriority/important-longterm

Description

Steps to reproduce the issue:

  1. Open config.json, run minikube node add minikube-m02
  2. Interrupt the add command after the node info presented in config.json but before ip is set
  3. Run minikube stop && minikube start, the node couldn't start

Contributor guide

Tech stack
gokubernetes
Domain
backenddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Go knowledgeunderstanding of minikube node lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how minikube node add writes to config.json and how minikube start reads node information. The issue occurs when a node is partially added (IP not set). Look into the start command's logic that checks for nodes with empty IPs and consider deleting such nodes or fetching a valid IP. Relevant files likely include pkg/minikube/node/ and pkg/minikube/config/. Comments in the issue suggest similar approaches; consider handling the incomplete node state gracefully.