kubernetes/minikube

Calling Docker daemon even for other container runtimes

Open

#8,577 opened on Jun 26, 2020

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Go (31,799 stars) (5,222 forks)batch import
co/runtime/containerdco/runtime/criohelp wantedkind/buglifecycle/frozenpriority/backlog

Description

From https://github.com/kubernetes/minikube/issues/8554#issuecomment-650387112

Still have a lot of unconditional calls to Docker, around the code base:

DigestByDockerLib

ExistsImageInDaemon

LoadFromTarball

WriteImageToDaemon

Usually these fail since we stop dockerd, but should be conditionalized.

Contributor guide

Tech stack
godocker
Domain
backenddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Gominikube codebase structurecontainer runtime abstraction
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue identifies several functions (DigestByDockerLib, ExistsImageInDaemon, LoadFromTarball, WriteImageToDaemon) that unconditionally call the Docker daemon. The first step is to understand how minikube currently handles different container runtimes (e.g., Docker, containerd, CRI O) by examining the runtime abstraction layer. Then, conditionalize these functions to only call Docker when the active runtime is Docker. Look at existing conditional checks in the codebase for patterns. The linked comment in issue #8554 provides additional context. It may be helpful to search for other similar unconditional Docker calls beyond those listed.