kubernetes/minikube

rename "none" driver to "native"

Open

#7,772 opened on Apr 18, 2020

View on GitHub
 (19 comments) (1 reaction) (0 assignees)Go (31,799 stars) (5,222 forks)batch import
co/none-driverhelp wantedkind/featurelifecycle/frozenpriority/backlog

Description

none is a terrible name. and doesnt look good at least in integration tests.I suggest we add an alias to none driver.

we could do it in two phases:

change all the current integration tests names to BareMetal in second phase, if we add an alias, so both none or barmetal be accepted.

Contributor guide

Tech stack
go
Domain
devopsinfrastructuretooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programming languageUnderstanding of minikube driver interfaceFamiliarity with Go testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the current 'none' driver implementation, likely in pkg/minikube/drivers/none. Note the comment from f1sherman about the table driven test approach in pkg/minikube/cluster/cluster test.go. Also, check the integration tests referenced (test/integration/). The issue proposes two phases: first, rename existing references to 'BareMetal' in tests, then add an alias so both 'none' and 'native' (or 'baremetal') are accepted. The maintainers seem open to this but need a concrete plan. Investigate if there are any configuration files or constants that reference the driver name.
rename "none" driver to "native" · kubernetes/minikube#7772 | Good First Issue