kubernetes/minikube

Add Progress bar: Transferring cached image

Open

#7,175 opened on Mar 23, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Go (5,222 forks)batch import
cmd/cachehelp wantedkind/featurelifecycle/frozenpriority/backlogsig/ui

Repository metrics

Stars
 (31,799 stars)
PR merge metrics
 (Avg merge 18d 3h) (62 merged PRs in 30d)

Description

I've recently started making use of the minikube image cache. When starting minikube, the startup stalls for a very long time at the following:

😄  minikube v1.8.2 on Linuxmint 19.3
✨  Using the kvm2 driver based on user configuration
🔥  Creating kvm2 VM (CPUs=8, Memory=18432MB, Disk=40000MB) ...
🐳  Preparing Kubernetes v1.17.3 on Docker 19.03.6 ...
🚀  Launching Kubernetes ... 
🌟  Enabling addons: default-storageclass, storage-provisioner

The first few times I encountered this, I though something had broken. It would be helpful to indicate to the user that progress is being made.

Contributor guide

Research direction
Start by examining the minikube startup flow in the `cmd/minikube/cmd/start.go` file. The image cache transfer likely occurs in the `pkg/minikube/machine` or `pkg/minikube/cache` directories. Look for functions that handle transferring cached images from host to VM. Consider using a progress bar library like `github.com/cheggaaa/pb` or the built in `spinner` package used elsewhere. Review existing progress bar implementations in the codebase for patterns, such as in `pkg/minikube/constants/progress.go`. The issue is open and no one has submitted a PR, so it's available for contribution.
Tech stack
godockerkubernetes
Domain
clibackenddeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go programmingFamiliarity with minikube codebaseUnderstanding of image caching
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65