kubernetes/minikube

profile list returns non-zero if a cluster is not running

Open

#6,743 opened on Feb 22, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (31,799 stars) (5,222 forks)batch import
help wantedkind/bugkind/featurelifecycle/frozenpriority/backlog

Description

when I was looking at this intergeration test that failed because profile list says one of the clusters is not running yet...

https://storage.googleapis.com/minikube-builds/logs/6717/e653589/Docker_Linux.html#fail_TestFunctional%2fparallel%2fProfileCmd%2fprofile_list

and also one of the users who was using minikube in a test script,... made me think.

When are the resonable times to exit none-zero for profile list ?

currently we exit non-zero for the following:

  • If there is no profile .
  • if there are a few profiles are one of them has error to give status running.

Contributor guide

Tech stack
go
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the current implementation of the `profile list` command in the minikube Go source code, likely in `cmd/minikube/cmd/profile list.go`. Understand the existing exit code logic and the cases where non zero is returned. Review the referenced integration test failure (https://storage.googleapis.com/minikube builds/logs/6717/e653589/Docker Linux.html#fail TestFunctional%2fparallel%2fProfileCmd%2fprofile list) to see the expected behavior. Participate in the issue discussion to clarify the desired exit code semantics for cases like a cluster not running.