kubernetes/minikube

move viper calls from packages into cmd to improve testability/resusablitily

Open

#21670 opened on Sep 30, 2025

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Go (31,799 stars) (5,222 forks)batch import
help wantedkind/cleanuppriority/important-soon

Description

packages inside minikube should not be calling viper to get a config, the viper (getting confg flags) should only be called form Cmd packages

this will help better testing and also avoid race conditions in Setting or Getting Flags in Parallel testing and Parallel usage of minikube and make minikube code more reusable and more testable

Originally posted by @medyagh in https://github.com/kubernetes/minikube/pull/21635#discussion_r2392461773

Contributor guide

Tech stack
go
Domain
backenddeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingViper configuration libraryMinikube project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the typical Viper configuration usage in Minikube's internal packages. Review the refactor example in PR #21635 and the discussion at https://github.com/kubernetes/minikube/pull/21635#discussion r2392461773. Identify all packages that directly call viper and plan to move those calls to the cmd layer. Ensure that configuration is passed as parameters to avoid global state.