kubernetes/minikube

fix "update-amd-gpu-device-plugin-version"

Open

#21195 opened on Jul 29, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (31,799 stars) (5,222 forks)batch import
cause/libmachine-bughelp wantedkind/process

Description

While testing https://github.com/kubernetes/minikube/pull/21186 I found out make update-amd-gpu-device-plugin-version also not working

$ make update-amd-gpu-device-plugin-version
cd hack && go run update/amd_device_plugin_version/update_amd_device_plugin_version.go
I0729 13:20:21.920950   34734 update_amd_device_plugin_version.go:50] Stable version: v1.25.2
F0729 13:20:22.899396   34734 update_amd_device_plugin_version.go:53] failed to get image SHA: failed to pull image: exit status 1: Error response from daemon: manifest for rocm/k8s-device-plugin:v1.25.2 not found: manifest unknown: manifest unknown
goroutine 1 [running]:

it tries to pul docker v1.25.2 https://hub.docker.com/r/rocm/k8s-device-plugin/tags which is not available but and 1.25.2.8 is availble

-btw the latest tag is v1.31.07 https://github.com/ROCm/k8s-device-plugin/releases why it is not trying to fetch that ??- never mind that is a pre-release

also could we make the ghSearchLimit = 300 configurable for Non-Kubernetes Repos ?( we have been hitting the rate limit)

Contributor guide

Tech stack
godockerkubernetes
Domain
build systemdevopscloud
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic GoFamiliarity with minikube buildDocker image pulling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is in hack/update/amd device plugin version/update amd device plugin version.go. The script tries to pull a specific Docker image tag (v1.25.2) that does not exist on Docker Hub. The fix should update the stable version logic to fetch the correct latest release tag from the ROCm/k8s device plugin repository or make the version configurable. Additionally, the hardcoded ghSearchLimit constant could be made configurable to avoid rate limits. The researcher should examine the script's logic and the upstream releases to propose a fix.